Fix incorrect endpoints in User registration and retrieval feature tests #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ster Fix incorrect endpoint in User registration feature tests
Fix incorrect endpoint in User show feature test
zigzagdev
commented
Jul 8, 2025
There was a problem hiding this comment.
Self Review
- Replaced incorrect endpoint
'api/user/register'with'api/users/register'inUser_RegisterTest - Replaced incorrect endpoint
'api/user/show/{id}'with'api/users/show/{id}'inUser_ShowTest - Confirmed routes exist in API routing:
Route::prefix('users')->group(function () { Route::post('register', ...); Route::get('show/{id}', ...); });
- Executed both tests and confirmed successful response status codes (e.g., 201, 200)
- Ensured that assertions and payload structures remained unchanged and valid
- Verified that test logic is still aligned with real application behaviour
Closed
Closed
Closed
There was a problem hiding this comment.
Pull Request Overview
This PR fixes incorrect API endpoint paths in the User feature tests and improves test method naming.
- Corrected
api/user/...toapi/users/...in both show and register tests - Renamed test methods to more descriptive names
- Adjusted property declaration in
User_ShowTest
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/app/User/Tests/User_ShowTest.php | Removed User type-hint, renamed tests, fixed GET endpoint to api/users/show/{id} |
| src/app/User/Tests/User_RegisterTest.php | Renamed tests and fixed POST endpoint to api/users/register |
Comments suppressed due to low confidence (2)
src/app/User/Tests/User_ShowTest.php:55
- [nitpick] The test name suggests this is a failure case, but it still asserts a 200 response. Consider renaming to reflect that it's a successful retrieval scenario.
public function test_failed_with_invalid_property(): void
src/app/User/Tests/User_ShowTest.php:12
- The property declaration has lost its
Usertype-hint. Re-addingprivate User $user;will improve type safety and IDE support.
private $user;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses and corrects the routing paths used in two feature tests concerning the User API:
User_RegisterTestUser_ShowTest(assumed)Both tests previously referred to incorrect endpoint patterns:
api/user/register→ should beapi/users/registerapi/user/show/{id}→ should beapi/users/show/{id}